[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xen: domain_update_node_affinity: Correct the ASSERT
Hi Jan, On 07/29/2014 07:40 AM, Jan Beulich wrote: >>>> On 28.07.14 at 19:31, <julien.grall@xxxxxxxxxx> wrote: >> On 07/28/2014 06:25 PM, Dario Faggioli wrote: >>> On ven, 2014-07-25 at 16:30 +0100, Julien Grall wrote: >>>> The commit "move domain to cpupool0 before destroying it" make Xen crashes >>>> when a domain is destroyed with d->vcpus allocated but no VCPU initialized. >>>> >>> The title of the commit is certainly useful. Perhaps the beginning of >>> the hash would have been too. >> >> I didn't add the commit. Because it will be backported to Xen 4.4. >> >> Would it be fine to point to a Xen 4.5 commit in Xen 4.4 branch? > > Yes. Backports are (supposed to be) identifiable (via some kind of > reference to the backported commit), which would implicitly mean > any commit IDs referenced in the description refer to the master > branch. Furthermore, if someone wanted to look up the > referenced commit, having the (beginning of the) hash in hands > makes this a much more immediate action than just the title; I > believe such a lookup would even succeed on any of the stable > branches, as - luckily - we decided to make them branches rather > than standalone trees. Thank you for the explanation. I will send a v2 today with the commit ID of xen unstable in the message. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |