[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xen: domain_update_node_affinity: Correct the ASSERT
Hi Dario, On 07/28/2014 06:25 PM, Dario Faggioli wrote: > On ven, 2014-07-25 at 16:30 +0100, Julien Grall wrote: >> The commit "move domain to cpupool0 before destroying it" make Xen crashes >> when a domain is destroyed with d->vcpus allocated but no VCPU initialized. >> > The title of the commit is certainly useful. Perhaps the beginning of > the hash would have been too. I didn't add the commit. Because it will be backported to Xen 4.4. Would it be fine to point to a Xen 4.5 commit in Xen 4.4 branch? >> Assertion '!cpumask_empty(dom_cpumask)' failed at domain.c:452 >> Xen call trace: >> [<00207bd8>] domain_update_node_affinity+0x10c/0x238 (PC) >> [<00000004>] 00000004 (LR) >> [<00226870>] sched_move_domain+0x3cc/0x42c >> [<0020925c>] domain_kill+0xc8/0x178 >> [<00206a0c>] do_domctl+0xaac/0x15e4 >> [<002529c0>] do_trap_hypervisor+0xc5c/0xf94 >> [<002559f0>] return_from_trap+0/0x4 >> >> Fix the ASSERT to check if d->vcpu is allocated and VCPU 0 is initialized. >> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> >> Cc: George Dunlap <george.dunlap@xxxxxxxxxx> >> Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx> >> Cc: Juergen Gross <jgross@xxxxxxxx> >> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx> >> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> >> Cc: Jan Beulich <jbeulich@xxxxxxxx> >> Cc: Keir Fraser <keir@xxxxxxx> >> Cc: Tim Deegan <tim@xxxxxxx> >> > In any case: > > Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx> Thanks! Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |