[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 07/12] create handle_cmdline() function

>>> On 28.07.14 at 17:44, <Ian.Campbell@xxxxxxxxxx> wrote:
> On Thu, 2014-07-24 at 08:36 +0100, Jan Beulich wrote:
>> >>> On 22.07.14 at 02:43, <roy.franz@xxxxxxxxxx> wrote:
>> > Create handle_cmdline() function in preparation for sharing to allow x86 
> and
>> > ARM architectures to share the command line processing.
>> I again can't see why the function doesn't get moved to the shared
>> file right away. And of course the splitting out again is questionable
>> considering that efi_start() itself ought to ultimately become a
>> shared function. By now I think you should have taken this the
>> other way round: Move the whole xen/arch/x86/efi/ subtree to
>> xen/common/efi/ and _then_ split out x86 specific code (possibly
>> into inline functions or #define-s rather than out of line code).
> Are you implying that you want to see it redone that way or just
> commenting but thinking "what's done is done"?

I guess I can live with it remaining the way it's done now, but I'd
much prefer it to be re-done as outlined unless there's a clear
indication against doing so. The extra work this incurs is certainly a
result of starting the coding without first announcing the plan (I
knew the split up would be wanted at some point, but I wasn't aware
that it got already started by the time I saw the first version of the
series, which then also was - I think - quite different from the v2
we're looking at now; had I known, I might have offered seeing to
do this myself).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.