Re: [Xen-devel] [PATCH V2 07/12] create handle_cmdline() function

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.07.14 at 02:43, <roy.franz@xxxxxxxxxx> wrote:
> Create handle_cmdline() function in preparation for sharing to allow x86 and
> ARM architectures to share the command line processing.

I again can't see why the function doesn't get moved to the shared
file right away. And of course the splitting out again is questionable
considering that efi_start() itself ought to ultimately become a
shared function. By now I think you should have taken this the
other way round: Move the whole xen/arch/x86/efi/ subtree to
xen/common/efi/ and _then_ split out x86 specific code (possibly
into inline functions or #define-s rather than out of line code).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel