[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 10/12] add arm64 cache flushing code from linux

To: Roy Franz <roy.franz@xxxxxxxxxx>
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Mon, 28 Jul 2014 16:53:56 +0100
Cc: keir@xxxxxxx, tim@xxxxxxx, xen-devel@xxxxxxxxxxxxx, stefano.stabellini@xxxxxxxxxx, jbeulich@xxxxxxxx, linaro-uefi@xxxxxxxxxxxxxxxx, fu.wei@xxxxxxxxxx
Delivery-date: Mon, 28 Jul 2014 15:57:36 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On Mon, 2014-07-21 at 17:43 -0700, Roy Franz wrote:
> +     .globl __flush_dcache_all
> +__flush_dcache_all:

Please use GLOBAL().

Other than that looks good (although I'm mostly taking it on trust that
the Linux version of this isn't broken):
        Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH V2 10/12] add arm64 cache flushing code from linux
  - From: Ian Campbell

References:
- [Xen-devel] [PATCH V2 00/12] arm64 EFI stub
  - From: Roy Franz
- [Xen-devel] [PATCH V2 10/12] add arm64 cache flushing code from linux
  - From: Roy Franz

Prev by Date: Re: [Xen-devel] [PATCH V2 01/12] Create efi-shared.[ch], and move string functions
Next by Date: Re: [Xen-devel] [PATCH V2 07/12] create handle_cmdline() function
Previous by thread: [Xen-devel] [PATCH V2 10/12] add arm64 cache flushing code from linux
Next by thread: Re: [Xen-devel] [PATCH V2 10/12] add arm64 cache flushing code from linux
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.