Re: [Xen-devel] [PATCH] fix list_domain_details: check config data length=0

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-07-24 at 13:48 +0100, Ian Jackson wrote:
> Chun Yan Liu writes ("Re: [PATCH] fix list_domain_details: check config data 
> length=0"):
> > >>> On 7/23/2014 at 05:53 PM, in message
> > <1406109196.1351.37.camel@xxxxxxxxxxxxxxxxxxxxxx>, Ian Campbell
> > <Ian.Campbell@xxxxxxxxxx> wrote: 
> > > I think this issue is resolved by Wei's "libxl: synchronise domain 
> > > configuration" series? That will save state in such a way that xl can 
> > > list libvirt domains etc. 
> > 
> > Yes, right. I missed Wei's patch series. Just have a look at that, this 
> > issue
> > is solved by that patch series. Thanks Wei and Ian!
> 
> Maybe we should commit Chun's patch to -unstable now so that it can be
> tested and backported to earlier trees.

I hadn't realised that libxl_userdata_retrieve signals ENOENT via
datalen == 0 rather than an error code. So it could certainly be argued
that a zero size userdata is something we should handle irrespective of
Wei's series, yes.

> It looks like a reasonable change to me:
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel