[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] fix list_domain_details: check config data length=0

>>> On 7/23/2014 at 05:53 PM, in message
<1406109196.1351.37.camel@xxxxxxxxxxxxxxxxxxxxxx>, Ian Campbell
<Ian.Campbell@xxxxxxxxxx> wrote: 
> On Wed, 2014-07-23 at 17:42 +0800, Chunyan Liu wrote: 
> > If domain is created through virsh, then in xl, one could see it 
> > with 'xl list', but with 'xl list --long domU', it reports: 
> > "Domain name must be specified." 
> > The reason is xl config data does not exist but it still tries 
> > to parse_config_data in current code. 
> >  
> > Improve list_domain_details: 
> > If len of config data is 0, just pass, do not go forward to 
> > parse_config_data, otherwise, it will meet error like 
> > "Domain name not specified" and exit. This error is not expected, 
> > since if code enters list_domain_details, domain name validness 
> > is already checked and domain does exist. 
> >  
> > Length of config data is 0 may means: config data does not exist due 
> > to some reason, like: domain is created by libvirt, or in destroying 
> > domain process config data is cleared but domain fails to clean up. 
> > No matter in which case, list_domain_details could just show empty 
> > info, but not error like "Domain name not specified". 
> >  
> > Signed-off-by: Chunyan Liu <cyliu@xxxxxxxx> 
> I think this issue is resolved by Wei's "libxl: synchronise domain 
> configuration" series? That will save state in such a way that xl can 
> list libvirt domains etc. 

Yes, right. I missed Wei's patch series. Just have a look at that, this issue
is solved by that patch series. Thanks Wei and Ian!

- Chunyan

> Ian. 

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.