[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [Patch v2 3/3] xen/gdbsx: Security audit of {, un}pausevcpu and domstatus hypercalls
>>> On 24.07.14 at 13:16, <andrew.cooper3@xxxxxxxxxx> wrote: > --- a/xen/arch/x86/domctl.c > +++ b/xen/arch/x86/domctl.c > @@ -1030,11 +1030,10 @@ long arch_do_domctl( > if ( !d->controller_pause_count ) > break; > ret = -EINVAL; > - if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu >= MAX_VIRT_CPUS || > + if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu >= d->max_vcpus || As mentioned on IRC - are you sure you can replace (rather than amend) the previous bounds check? I.e. do you _know_ that gdbsx can deal with guests having more than MAX_VIRT_CPUS vCPU-s? Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |