[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 3/3] xen/gdbsx: Security audit of {, un}pausevcpu and domstatus hypercalls
At 11:56 +0100 on 24 Jul (1406199410), Andrew Cooper wrote: > diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c > index 243f42f..6b2479e 100644 > --- a/xen/arch/x86/domctl.c > +++ b/xen/arch/x86/domctl.c > @@ -1030,11 +1030,10 @@ long arch_do_domctl( > if ( !d->controller_pause_count ) > break; > ret = -EINVAL; > - if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu >= MAX_VIRT_CPUS || > + if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu > d->max_vcpus || Not >= ? > (v = d->vcpu[domctl->u.gdbsx_pauseunp_vcpu.vcpu]) == NULL ) > break; > - vcpu_pause(v); > - ret = 0; > + ret = vcpu_pause_by_systemcontroller(v); > } > break; > > @@ -1046,13 +1045,14 @@ long arch_do_domctl( > if ( !d->controller_pause_count ) > break; > ret = -EINVAL; > - if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu >= MAX_VIRT_CPUS || > + if ( domctl->u.gdbsx_pauseunp_vcpu.vcpu > d->max_vcpus || Same thing here. Tim. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |