[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] stubdom/libxc-x86_64 compile error with valgrind installed
Andrew Cooper writes ("Re: [Xen-devel] stubdom/libxc-x86_64 compile error with valgrind installed"): > On 21/07/14 11:47, Ian Campbell wrote: > > On Mon, 2014-07-21 at 11:40 +0100, Andrew Cooper wrote: > >> Doesn't it need an extra check for the rump stuff? > > I don't know... > > > > Ian, the proposal is tools/libxc/xc_private.h: > > -#if defined(HAVE_VALGRIND_MEMCHECK_H) && !defined(NDEBUG) > > +#if defined(HAVE_VALGRIND_MEMCHECK_H) && !defined(NDEBUG) && > > !defined(__MINIOS__) ... > Nor do I, but IanJ's series changed most (all?) the #if > !defined(__MINIOS__) into #if !defined(__MINIOS__) || > !defined(__RUMPUSER_XEN__) > > Therefore, I suspect the same is needed here. No, this bodge isn't needed for __RUMPUSER_XEN__. The rump kernel build runs configure with the rump kernel build system which doesn't see the system's valgrind.h. I.e., the rump kernel build environment used for building tools/libxc/ doesn't have the bug that the stubdom build system has. There are some __RUMPUSER_XEN__ in libxc but they are just for selecting the right implementations of various components - in particular, to make hypercalls directly but use the devices in /dev/ for xenstore and evtchn. (And for disabling dynamic loading.) Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |