Re: [Xen-devel] stubdom/libxc-x86_64 compile error with valgrind installed

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-07-21 at 12:06 +0100, Ian Campbell wrote:
> On Mon, 2014-07-21 at 11:56 +0100, Andrew Cooper wrote:
> > On 21/07/14 11:47, Ian Campbell wrote:
> > > On Mon, 2014-07-21 at 11:40 +0100, Andrew Cooper wrote:
> > >> On 21/07/14 11:33, Ian Campbell wrote:
> > >>> On Mon, 2014-07-21 at 11:19 +0100, Andrew Cooper wrote:
> > >>>> I am not sure what is the correct solution here is.  Introducing an
> > >>>> explicit --{en,dis}able-valgrind to the main ./configure will still
> > >>>> break for anyone who chooses to enable it.
> > >>> I proposed a bodge which I think would be acceptable (assuming it works)
> > >> I saw.  It most certainly is a bodge, but is probably the best short
> > >> term course of action.
> > >>
> > >> Doesn't it need an extra check for the rump stuff?
> > > I don't know...
> > >
> > > Ian, the proposal is tools/libxc/xc_private.h:
> > > -#if defined(HAVE_VALGRIND_MEMCHECK_H) && !defined(NDEBUG)
> > > +#if defined(HAVE_VALGRIND_MEMCHECK_H) && !defined(NDEBUG) && 
> > > !defined(__MINIOS__)
> > >
> > > Ian.
> > >
> > 
> > Nor do I, but IanJ's series changed most (all?) the #if
> > !defined(__MINIOS__) into #if !defined(__MINIOS__) ||
> > !defined(__RUMPUSER_XEN__)
> > 
> > Therefore, I suspect the same is needed here.
> 
> && rather than || in this case though I think?

That said -- I'd have hoped that the rumpkernel changes would have
resulted in !HAVE_VALGRIND_MEMCHECK_H, so maybe not?


Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel