[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 1/9] mg-unixbench-download: new script for downloading the unixbench archive

On mer, 2014-07-16 at 16:02 +0100, Ian Campbell wrote:
> On Thu, 2014-06-26 at 15:02 +0200, Dario Faggioli wrote:
> > The script fetches it, and saves it in c{Images}/benchs.
> > 
> > Default values for URL and actual filename are in ap-common, and
> > can be overridden as usual.
> ap-* are to do with the pushing machinery, so I'm not sure this is the
> right place for it.
Right. Sorry then, I must have missed this.

> I think it would be OK to hardcode the URL into the script and put the
> version number in the config file (e.g. production-config). Perhaps with
> a default (in the script).
I'll do it this way.

> >  XXX: this may or may not be something suitable to do in a
> >       function in cri-common, called by ap-fetch-version. It's
> >       not a git tree, and it's not something that changes much
> >       so I think it's fine like it is in this patch. If it is
> >       not, advise otherwise and I'll cope.
> The usual approach would be to have a setup script (as you have done
> here) to populate an output directory rather than to run the dl on every
> run (as you propose in this comment, I think).
Great, less (re)work! :-)

Thanks and Regards,

<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.