Re: [Xen-devel] [PATCH RFC 2/9] ts-unixbench-prep: prep the environment for running unixbench

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On mer, 2014-07-16 at 16:09 +0100, Ian Campbell wrote:
> > ---
> >  ts-unixbench-prep |   79 
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 79 insertions(+)
> >  create mode 100755 ts-unixbench-prep
> > 
> > diff --git a/ts-unixbench-prep b/ts-unixbench-prep
> > new file mode 100755
> > index 0000000..607d1a8
> > --- /dev/null
> > +++ b/ts-unixbench-prep
> > @@ -0,0 +1,79 @@
> > +#!/usr/bin/perl -w
> > +# This is part of "osstest", an automated testing framework for Xen.
> > +# Copyright (C) 2009-2013 Citrix Inc.
> 
> Out of date.
> 
Oops. :-)

> > +tsreadconfig();
> > +
> > +# what we expect as argument list is:
> > +#  host=<somehost> [<someguest>]
> > +our $ho= selecthost($ARGV[0]); shift @ARGV;
> 
> IIRC Ian just made select* consume ARGV, so the shift wouldn't be needed
> any more.
> 
Yeah, I saw it. I'll build on top of that as far as it will hit the
repo.

> > +our $gho= $ho;
> > +if ( (0+@ARGV) == 1) {
> 
> Is the 0+ needed, I thought arrays in scalar context evaluated to their
> length already without forcing it like that.
> 
Ehm, my Perl-fu is still very poor. ISTR trying and having some issues,
but yeah, I'll give it another shoot at doing things properly. Sorry :-)

> > +given ($ext) {
> > +  $extract_cmd= 'xf' when ('.tar');
> > +  $extract_cmd= 'zxf' when ['.tgz', '.gzip'];
> > +  $extract_cmd= 'jxf' when  ['.tbz2', '.bz2'];
> > +  default { die "unrecognised file extension $ext" }
> 
> I think "xaf" will automatically handle different compression algs. I'm
> just not quite sure what it does if the tarball is uncompressed.
> 
Oh, I did not know that, I'll give it a try. About the uncompressed
tarball case, I don't think we should worry much about being too
flexible here. Perhaps what I was trying to do above is already too
much. I mean, we expect the file to have a specific name, and to be in a
specific place already, we can well ask for it to be compressed, and
bail if it is not. What do you think?

> > +}
> > +
> > +# Prepare the target, by installing dependencies, and build the benchmark
> > +target_install_packages_norec($gho, qw(build-essential libx11-dev
> > +                                       libgl1-mesa-dev libxext-dev
> > +                                       x11-apps));
> > +target_cmd_root($gho, <<END, 200);
> > +        set -ex
> > +        rm -rf /root/unixbench/
> 
> Ideally you would use the osstest user. I'm not sure if that is set up
> for guests though, might be host only.
> 
I don't recall that either, and I'll check. There are benchmarks,
though, that wants to run as root... I guess that is not a big deal, at
least for guests, is it? For hosts, I see it could be a bigger issue...

Thanks again and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel