Re: [Xen-devel] [PATCH RFC 1/9] mg-unixbench-download: new script for downloading the unixbench archive

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-26 at 15:02 +0200, Dario Faggioli wrote:
> The script fetches it, and saves it in c{Images}/benchs.
> 
> Default values for URL and actual filename are in ap-common, and
> can be overridden as usual.

ap-* are to do with the pushing machinery, so I'm not sure this is the
right place for it.

I think it would be OK to hardcode the URL into the script and put the
version number in the config file (e.g. production-config). Perhaps with
a default (in the script).

>  XXX: this may or may not be something suitable to do in a
>       function in cri-common, called by ap-fetch-version. It's
>       not a git tree, and it's not something that changes much
>       so I think it's fine like it is in this patch. If it is
>       not, advise otherwise and I'll cope.

The usual approach would be to have a setup script (as you have done
here) to populate an output directory rather than to run the dl on every
run (as you propose in this comment, I think).

All ones for Ian J though really.

Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel