[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] Move xenstore and libxc public headers to include subdir

On 11/07/14 16:21, Ian Campbell wrote:
> On Fri, 2014-07-11 at 16:20 +0100, Andrew Cooper wrote:
>> Not directly related to your patch but...
>> andrewcoop@andrewcoop:/local/xen.git/tools/qemu-xen-dir-remote$ git grep
>> "xs\.h"
>> configure:#include <xs.h>
>> configure:#include <xs.h>
>> configure:#include <xs.h>
>> configure:#include <xs.h>
>> include/hw/xen/xen_common.h:#  include <xs.h>
>> Isn't it time we got code like this off using the legacy xs.h?
> So long as that code also wants to build against older Xen we should
> tolerate them preferring the older headers.

The whole purpose of configure is to try and hide that stuff away. 
Surely it should try looking for xenstore.h and, failing that, look for
xs.h and fill in some variable?

We know for certain whether the version of qemu pointed to by xen.git
need the legacy headers still.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.