Re: [Xen-devel] [PATCH v2] Move xenstore and libxc public headers to include subdir

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-07-11 at 16:29 +0100, Andrew Cooper wrote:
> On 11/07/14 16:21, Ian Campbell wrote:
> > On Fri, 2014-07-11 at 16:20 +0100, Andrew Cooper wrote:
> >
> >> Not directly related to your patch but...
> >>
> >> andrewcoop@andrewcoop:/local/xen.git/tools/qemu-xen-dir-remote$ git grep
> >> "xs\.h"
> >> configure:#include <xs.h>
> >> configure:#include <xs.h>
> >> configure:#include <xs.h>
> >> configure:#include <xs.h>
> >> include/hw/xen/xen_common.h:#  include <xs.h>
> >>
> >> Isn't it time we got code like this off using the legacy xs.h?
> > So long as that code also wants to build against older Xen we should
> > tolerate them preferring the older headers.
> >
> >
> >
> 
> The whole purpose of configure is to try and hide that stuff away. 
> Surely it should try looking for xenstore.h and, failing that, look for
> xs.h and fill in some variable?

Qemu's ./configure is not autoconf.

In any case while it could do what you suggest I don't think these spare
headers are causing us such grief that we need to make waves about
getting rid of them.

> 
> We know for certain whether the version of qemu pointed to by xen.git
> need the legacy headers still.
> 
> ~Andrew



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel