Re: [Xen-devel] [PATCH v2] Move xenstore and libxc public headers to include subdir

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-07-11 at 15:48 +0100, Stefano Stabellini wrote:
> Also moves xc_dom.h to include as it is used often by other xen tools.

I think you could say here "expected to be used by other in-tree xen
tools despite not currently being installed" or something to make it
clear that this isn't one of the many bad cases.

> Use the new include subdirectories to build Xen tools and qemu-xen.
> 
> Add the old libxc include path to the programs that need it to build,
> on a case by case basis and commeting that they shouldn't require

"commenting"

> internal libxc headers to build.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

This looks good to me, but ISTR you saying something about a qemu-trad
update which needed to be synchronised?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel