Re: [Xen-devel] [PATCH] Kernel OOPS in xen_netbk_rx_action / xenvif_gop_skb

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jul 11, 2014 at 01:02:18PM +0200, Philipp Hahn wrote:
> Hello Wei Liu,
> 
> On 11.07.2014 12:32, Wei Liu wrote:
> > On Fri, Jul 11, 2014 at 11:41:22AM +0200, Philipp Hahn wrote:
> >> On 10.07.2014 14:41, Wei Liu wrote:
> >>> On Wed, Jul 02, 2014 at 09:45:44AM +0200, Philipp Hahn wrote:
> >>>> @Wei Liu: You said that the patch is only a quick hack to 
> >>>> detect, if my analysis is correct and a proper fix would be 
> >>>> needed. For us the attached patch works, as the problem does 
> >>>> not happen that often and is hard to reproduce anyway, so 
> >>>> spending more time on that issue is probably not worth it. And 
> >>>> that flag doesn't look that ugly.
> >> ...
> >>> I agree that we would like to avoid spending too much time on 
> >>> this issue.
> >> 
> >> This is also what I'm thinking.
> >> 
> >>> Since the problem is confirmed, I think a proper fix will be to 
> >>> reference count vif and prevent it from unmapping the ring
> >>> before all queued SKBs are consumed.
> >> 
> >> vif is already ref-counted; see attached *untested* patch for a 
> >> start.
> 
> v2 = using refcnt
> 

Oh I see, I misread your email. You actually sent me two patches, sorry.
I looked at your first one and somehow missed second one.

Unfortunately your patch with refcnt won't work. 

> >> The quick hack now runs on that system for several weeks now 
> >> without problems.
> 
> v1 = Your quick hack patch + my additional dev_kfree_skb(skb);

I guess you mean "my additional xenvif_put". :-)

I will see what I can do.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel