Re: [Xen-devel] [PATCH] Kernel OOPS in xen_netbk_rx_action / xenvif_gop_skb

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jul 11, 2014 at 11:41:22AM +0200, Philipp Hahn wrote:
> Hello Wei Liu,
> 
> On 10.07.2014 14:41, Wei Liu wrote:
> > On Wed, Jul 02, 2014 at 09:45:44AM +0200, Philipp Hahn wrote:
> >> @Wei Liu: You said that the patch is only a quick hack to detect, if my
> >> analysis is correct and a proper fix would be needed. For us the
> >> attached patch works, as the problem does not happen that often and is
> >> hard to reproduce anyway, so spending more time on that issue is
> >> probably not worth it. And that flag doesn't look that ugly.
> ...
> > I agree that we would like to avoid spending too much time on this
> > issue.
> 
> This is also what I'm thinking.
> 
> > Since the problem is confirmed, I think a proper fix will be to
> > reference count vif and prevent it from unmapping the ring before all
> > queued SKBs are consumed.
> 
> vif is already ref-counted; see attached *untested* patch for a start.
> 

[...]

> 
> The quick hack now runs on that system for several weeks now without
> problems.
> 

I'm a bit confused, you said that patch was *untested*, then you said
the hack runs fine.

I guess what you meant is: the approach is generally working but the
patch you submitted is not the one running in your system? Is there
significant difference between the patch you submitted and the one
you're using in production?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel