Re: [Xen-devel] [PATCH] tools/libxc: Introduce typesafe and side-effect safe min()/max() macros

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2014-07-10 at 10:41 +0100, Andrew Cooper wrote:
> On 10/07/14 10:35, Ian Campbell wrote:
> > On Wed, 2014-07-09 at 16:54 +0100, Ian Campbell wrote:
> >> On Tue, 2014-07-08 at 14:21 +0100, Andrew Cooper wrote:
> >>> Replace the current users, and remove scattered re-definitions.
> >>>
> >>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >> Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> >>
> >>> -                unsigned long sz = MIN(chunk_bytes, sizeof(xen_pfn_t));
> >>> +                unsigned long sz = min((size_t)chunk_bytes, 
> >>> sizeof(xen_pfn_t));
> >> FWIW on the hyperevisor side we have max_t and min_t to handle these
> >> cases where a cast is needed.
> > Which I've just noticed/remembered I promoted to xc_private.h in my ARM
> > p2m superpages series!
> 
> I noticed that.  I guess it depends which patch gets committed first.

I've just committed a batch of patches which includes my min_t/max_t
one.

> This patch is a prerequisite of the writev() patch, which is a
> prerequisite for my migration v2.
> 
> If you wish, I can do a v2 which moves min_t/max_t at the same time and
> uses them in preference.

If you rebase onto staging  should get min_t and max_t provided already,
then a v2 which uses them as appropriate would be appreciated, thanks.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel