[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] tools/libxc: Introduce typesafe and side-effect safe min()/max() macros
On Wed, 2014-07-09 at 16:54 +0100, Ian Campbell wrote: > On Tue, 2014-07-08 at 14:21 +0100, Andrew Cooper wrote: > > Replace the current users, and remove scattered re-definitions. > > > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > > Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx> > > > - unsigned long sz = MIN(chunk_bytes, sizeof(xen_pfn_t)); > > + unsigned long sz = min((size_t)chunk_bytes, > > sizeof(xen_pfn_t)); > > FWIW on the hyperevisor side we have max_t and min_t to handle these > cases where a cast is needed. Which I've just noticed/remembered I promoted to xc_private.h in my ARM p2m superpages series! > I think it's a little bit safer too since rather than casting it assigns > the arguments to temporary variables of the named types (so any type > promotion etc mismatches are flagged rather than hidden by the cast). > > Ian. > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxx > http://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |