[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3] xen/arm: introduce PLATFORM_QUIRK_GUEST_PIRQ_NEED_EOI
On Wed, 2014-07-09 at 16:11 +0100, Stefano Stabellini wrote: > > > Stefano, you might want to arrange in your patch to cache the value of > > > the quirk in the gicv2 struct -- otherwise all the calls to > > > platform_has_quirk are going to add up. > > > > Can't we cache the value in the platform code? I don't think it's too > > expensive to call the platform_has_quirk in this case. > > Caching the value in gic-v2.c seems a bit overkill. But we could turn > platform->quirks() into a bitfield, then we can significantly reduce > memory accesses when checking for quirks, from 3 to just 1. Hrm, yes. That does have the disadvantage of potentially un-consting the platform ops. Anyway, this patch is correct for now and the detection of the fixed platform can be done later. So applied with s/SGI/SPI in the commit log as discussed IRL. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |