[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH 3/4] Updated comments/variables to reflect cbs, fixed formatting and confusing comments/variables

On gio, 2014-06-26 at 17:24 -0400, Joshua Whitehead wrote:
> On 6/17/2014 1:28 PM, Dario Faggioli wrote:

> > The merge can happen 'either way', i.e., we can try to borrow the global
> > scheduling bits (i.e., the SMP support) from RT-Xen's sched_rtglobal.c
> > into sched_sedf.c or, vice-versa, import Josh's SEDF/CBS code inside
> > sched_rtglobal.c... In either case, I'd need Josh and Meng, and their
> > respective fellows, to collaborate... Are you guys up for that? :-)
> > 
> Reading over this again in combination with some of the other discussion that
> has gone on (and having seen the e-mails from Meng/RT-Xen, thanks for that!) 
> we
> think this is probably a good solution.
> To this end I think our next version of the patch series will focus on the
> reorganization of the patch order as discussed with the separation between the
> various areas.  We will keep our cuts to SEDF and our implementation details 
> on
> CBS, but we'll keep the the renaming/parameter changes very limited to only
> what's necessary to properly reflect the state of the scheduler. (Similar to
> what George proposed in his last e-mail, i.e. changing the scheduler and
> interface in place rather than introducing a new scheduler entirely)
Yes, that, I think, would help. As said, the series is very hard to
review like this. Having it in a better split and more 'focused' (i.e.,
less massive killing/renaming) would help (me) a lot!

> At a minimum this would put the series in a good state so that, if it were
> upstreamed, RT-Xen and/or DornerWorks could easily patch against the scheduler
> to add the additional features discussed.  These patches could then come
> directly from RT-Xen, DornerWorks, or some other hybrid of RT-Xen and
> DornerWorks code, all while occurring incrementally and leaving a working
> version of the scheduler in the tree at all times.
Right... That's the spirit!! :-D :-D

> Everyone let us know what you think, we'll get to work on our V2 to get that 
> out
> soon to give everyone a better idea of where that puts us.  Thanks,
Really, it would be super-cool. And thanks to you. :-)

<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.