[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH 1/4] Implement cbs algorithm, remove extra queues, latency scaling, and weight support from sedf

On gio, 2014-06-26 at 16:17 -0400, Joshua Whitehead wrote:
> On 6/17/2014 11:43 AM, Dario Faggioli wrote:

> > As I said, it's very hard to review the patch like this... Let me know
> > if you agree in splitting it, in which case, I'd rather have a look at
> > that version when it'll be ready.
> > 
> Yes I think splitting (as well as some of the other reorganization mentioned
> elsewhere) would be best and make it easier to review.  Some of the above 
> would
> also depend on how we decided to handle the input from George as it sounds 
> like
> he doesn't feel it would cause much of an issue to change the parameters 
> around.
>  I can't promise anything as we have other projects going on concurrently, but
> maybe we'll shoot to have a reorganized and cleaned up V2 out by next week.
Saying it once more, that would be great.

As per the renaming/removing, I'd say, for v2, do as George said. Change
in place, rename and remove the list (nothing?), at least from the
interface, and change the behavior whenever required.

Also, make sure you comply with the API stability requirement, at the
libxl level, as suggested also by George, by  means of the proper
LIBXL_HAVE_xxx and/or LIBXL_API_VERSION_xxx macros.

There are usage examples of both, in libxl sources.

Thanks and Regards,
<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.