Re: [Xen-devel] [RFC PATCH 3/4] Updated comments/variables to reflect cbs, fixed formatting and confusing comments/variables

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 06/16/2014 10:33 AM, Jan Beulich wrote:
> > > > On 13.06.14 at 21:58, <josh.whitehead@xxxxxxxxxxxxxxx> wrote:
> > --- a/xen/include/public/trace.h
> > +++ b/xen/include/public/trace.h
> > @@ -75,7 +75,7 @@
> >   /* Per-scheduler IDs, to identify scheduler specific events */
> >   #define TRC_SCHED_CSCHED   0
> >   #define TRC_SCHED_CSCHED2  1
> > -#define TRC_SCHED_SEDF     2
> > +#define TRC_SCHED_CBS      2
> While the change to domctl.h is fine, I'm not sure we can allow simple
> renaming elsewhere in the public headers (i.e. the old name may need
> to remain there, guarded with a __XEN_INTERFACE_VERSION__
> conditional).
I think the tracing stuff is fine too -- we've always considered that 
non-stable (and have made incompatible changes across versions).
But the libxl interfaces *do* need to have something sensible done with 
them.
Given that,  I think it would probably be better to make this patch series:

1/N: Add sched_cbs.c to Xen
2/N: Add cbs to toolstack
3/N: Remove sedf scheduler (with appropriate backwards-compatibility bits)

I think that would make it a bit easier to review as well.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel