Re: [Xen-devel] [PATCH v6 1/5] xen/arm: observe itargets setting in vgic_enable_irqs and vgic_disable_irqs

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 24/06/14 12:38, Stefano Stabellini wrote:
> > Sorry for not having catch this earlier. I don't really like the idea to
> > extend the rank lock to vgic_{enable/disable}_irqs. The 2 functions
> > can be long to execute as it may touch the GIC distributor.
> >
> > In another way, the rank lock is only taken in the distributor emulation.
> >
> > Assuming we consider that distributor access may be slow:
> We could end up enabling or disabling the wrong set of interrupts
> without this change. I think it is necessary.
AFAIU, this lock only protects the rank when we retrieve the target 
VCPU, the other part of the function will still work without it.
What I meant is to call vgic_get_target_vcpu, so the lock will protect 
only what is necessary and not more.
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel