Re: [Xen-devel] [PATCH osstest.git v3] Add libvirt build and test jobs.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-04-14 at 15:42 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH osstest.git v3] Add libvirt build and test 
> jobs."):
> > On Mon, 2014-04-14 at 12:11 +0100, Ian Jackson wrote:
> > > Sadly, you mustn't invoke apt here because this script might run in
> > > parallel on the same host with other scripts.
> > > 
> > > I had to make a similar comment in response to another patch
> > > recently.
> > 
> > Ah, I remember that now you mention it.
> > 
> > >   Perhaps it is time to fix this by wrapping the apt-get rune
> > > in with-lock-ex.
> > 
> > Can do. I'd also be happy to move these packages to the build-prep job.
> 
> I think adding the extra flexibility is probably better.  It might
> avoid quite a bit of needless installing of things.  It would also
> remove one more barrier sharing of test dom0s.

One concern I just had was that it could make some stuff be slightly
less deterministic, since it might depend more on what jobs previously
ran on the host. At least by having all packages installed to
ts-xen-build-prep we guarantee that everything sees the same set of
installed packages.

Now, we should be passing all the right options to configure etc to make
this issue moot -- but I bet we aren't.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel