Re: [Xen-devel] [PATCH osstest.git v3] Add libvirt build and test jobs.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH osstest.git v3] Add libvirt build and test 
jobs."):
> On Mon, 2014-04-14 at 12:11 +0100, Ian Jackson wrote:
> > Sadly, you mustn't invoke apt here because this script might run in
> > parallel on the same host with other scripts.
> > 
> > I had to make a similar comment in response to another patch
> > recently.
> 
> Ah, I remember that now you mention it.
> 
> >   Perhaps it is time to fix this by wrapping the apt-get rune
> > in with-lock-ex.
> 
> Can do. I'd also be happy to move these packages to the build-prep job.

I think adding the extra flexibility is probably better.  It might
avoid quite a bit of needless installing of things.  It would also
remove one more barrier sharing of test dom0s.

NB you'll probably want to replace the timeout with a fixed value.
The current timeout is a guess based on the number of packages which
wouldn't be right if "this" run could be queued up behind a much
larger run holding the lock.

> > > +# Loosely based on Debian libvirt-bin initscript:
> > > +# (c) 2007 Guido Guenther <agx@xxxxxxxxxxx>
> > > +# based on the skeletons that comes with dh_make
> > 
> > Does libvirt really not come with one ?
> 
> It's very RH specific and unusable in this context.

How unhelpful.  Fair enough.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel