Re: [Xen-devel] [PATCH osstest.git v3] Add libvirt build and test jobs.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-04-14 at 12:11 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH osstest.git v3] Add libvirt build and test 
> jobs."):
> > The ts-libvirt-build, sg-run-job and mfi-common changes have been tested in
> > standalone mode.
> ...
> 
> The ap-* and cr-daily-branch changes look good.

This continues to surprise me ;-)

> > diff --git a/ts-libvirt-build b/ts-libvirt-build
> > new file mode 100755
> > index 0000000..56b78f1
> ...
> > +sub prep() {
> > +    target_install_packages($ho, qw(autoconf automake libtool xsltproc
> > +                                    libxml2-utils libxml2-dev libnl-dev
> > +                                    libdevmapper-dev w3c-dtd-xhtml));
> > +}
> 
> Sadly, you mustn't invoke apt here because this script might run in
> parallel on the same host with other scripts.
> 
> I had to make a similar comment in response to another patch
> recently.

Ah, I remember that now you mention it.

>   Perhaps it is time to fix this by wrapping the apt-get rune
> in with-lock-ex.

Can do. I'd also be happy to move these packages to the build-prep job.

> > +sub libvirtd_init () {
> > +    return <<'END';
> > +#! /bin/sh
> > +#
> > +# Init script for libvirtd
> > +#
> > +# Loosely based on Debian libvirt-bin initscript:
> > +# (c) 2007 Guido Guenther <agx@xxxxxxxxxxx>
> > +# based on the skeletons that comes with dh_make
> 
> Does libvirt really not come with one ?

It's very RH specific and unusable in this context.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel