Re: [Xen-devel] [PATCH] xen/arm: traps: Add missing 0x in bad_trap

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/04/14 13:01, Ian Campbell wrote:
> On Thu, 2014-04-10 at 12:53 +0100, Andrew Cooper wrote:
>> On 10/04/14 12:44, Julien Grall wrote:
>>> The syndrome value is printed in hexadecimal. Prefix it by 0x for less
>>> confusion.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> Xen is trying to converge on '%#' rather than an explicit 0x.
> Really? I've been moving in the opposite direction because e.g. %010#lx
> does the wrong thing with zero (0000000000 instead of 0x00000000).
>
> Not sure about plain %#x though...

%#x DoesTheRightThing, and is a character shorter than its alternative. 
Jan appears to have replaced most of the x86 examples.

I also get slightly frustrated with Format strings with an explicit
width do the specified thing (limit the length of the entire formatted
entry), rather than the useful thing (sticking '0x' before a number with
an explicit width).

By the time you have got a zero-extended explicitly-width'd format
string, the 0x is hardly the end of the world

>
>> Also, it looks as if you want to do the same for IL
> IL must be 2 or 4, for clarity it would be better as %d rather than 0x%x
> I think.

Agreed

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel