Re: [Xen-devel] [PATCH] xen/arm: traps: Add missing 0x in bad_trap

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-04-10 at 12:53 +0100, Andrew Cooper wrote:
> On 10/04/14 12:44, Julien Grall wrote:
> > The syndrome value is printed in hexadecimal. Prefix it by 0x for less
> > confusion.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Xen is trying to converge on '%#' rather than an explicit 0x.

Really? I've been moving in the opposite direction because e.g. %010#lx
does the wrong thing with zero (0000000000 instead of 0x00000000).

Not sure about plain %#x though...

> Also, it looks as if you want to do the same for IL

IL must be 2 or 4, for clarity it would be better as %d rather than 0x%x
I think.

> 
> ~Andrew
> 
> > ---
> >  xen/arch/arm/traps.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> > index 9eeed92..858abe5 100644
> > --- a/xen/arch/arm/traps.c
> > +++ b/xen/arch/arm/traps.c
> > @@ -1616,7 +1616,7 @@ asmlinkage void do_trap_hypervisor(struct 
> > cpu_user_regs *regs)
> >          break;
> >      default:
> >   bad_trap:
> > -        printk("Hypervisor Trap. HSR=0x%x EC=0x%x IL=%x 
> > Syndrome=%"PRIx32"\n",
> > +        printk("Hypervisor Trap. HSR=0x%x EC=0x%x IL=%x 
> > Syndrome=0x%"PRIx32"\n",
> >                 hsr.bits, hsr.ec, hsr.len, hsr.iss);
> >          do_unexpected_trap("Hypervisor", regs);
> >      }
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel