Re: [Xen-devel] [PATCH] xen/arm: traps: Add missing 0x in bad_trap

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/04/14 12:44, Julien Grall wrote:
> The syndrome value is printed in hexadecimal. Prefix it by 0x for less
> confusion.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Xen is trying to converge on '%#' rather than an explicit 0x.

Also, it looks as if you want to do the same for IL

~Andrew

> ---
>  xen/arch/arm/traps.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 9eeed92..858abe5 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -1616,7 +1616,7 @@ asmlinkage void do_trap_hypervisor(struct cpu_user_regs 
> *regs)
>          break;
>      default:
>   bad_trap:
> -        printk("Hypervisor Trap. HSR=0x%x EC=0x%x IL=%x 
> Syndrome=%"PRIx32"\n",
> +        printk("Hypervisor Trap. HSR=0x%x EC=0x%x IL=%x 
> Syndrome=0x%"PRIx32"\n",
>                 hsr.bits, hsr.ec, hsr.len, hsr.iss);
>          do_unexpected_trap("Hypervisor", regs);
>      }


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel