[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Restart domU failure (memory allocation issue)



On 03/14/2014 02:05 PM, Andrii Anisov wrote:
>     This is done in kernel space. When you map the pages, privcmd will set
>     specific callbacks that will be use when munmap will be called (see
>     privcmd_close in drivers/xen/privcmd.c).
>     The privcmd_close function will call the hypercall to remove the foreign
>     page from the p2m.
> 
> 
> We will check if it works on our site (but it looks it does not).

I think I've found why ... the privcmd_close is buggy on 3.8. You might
need to backport this commit:

commit 9eff37a8713939f218ab8bf0dc93f1d67af7b8b4
Author: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date:   Mon Nov 5 09:42:17 2012 +0300

    xen/privcmd: fix condition in privcmd_close()
    
    The parenthesis are in the wrong place so the original code is
    equivalent to:
    
        if (!xen_feature(XENFEAT_writable_descriptor_tables)) { ...
    
    Which obviously was not intended.
    
    Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.