Re: [Xen-devel] [PATCH] xen: Don't use -nostdinc flags with CLANG

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 02/13/2014 11:46 AM, George Dunlap wrote:
> On 02/13/2014 11:24 AM, Tim Deegan wrote:
> > George: ping.
> >
> > At 15:33 +0100 on 11 Feb (1392129226), Tim Deegan wrote:
> > > At 14:24 +0000 on 11 Feb (1392125052), Julien Grall wrote:
> > > > If it's possible I'd like this patch goes in Xen 4.4 to fix build with
> > > > official version of clang (until 3.4).
> > > >
> > > > Clang 3.5 is still under development, so I don't think it's 
> > > > important to
> > > > have support for it in Xen 4.4.
> > > Fair enough.  In that case it needs a release ack from George.  It:
> > >   - fixes a compile issue on some version s of clang;
> > >   - might cause a regression with other compilers, but the regression
> > >     is likely to be obvious (i.e. a compile-time failure).
> So the main risk would be if stgarg.h contained something like the 
> "__GNUC_PREREQ__(4, 5)" #ifdef-ery that we missed.
Sorry, realized the grammar was ambiguous here.  For the record, I 
meant, the risk would be a system where the stdarg.h contained something 
of that type that our own copy didn't.
-G

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel