[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: Don't use -nostdinc flags with CLANG

(Add George as release manager)

On 11/02/14 13:59, Tim Deegan wrote:
At 13:20 +0000 on 11 Feb (1392121252), Julien Grall wrote:

On 11/02/14 12:59, Tim Deegan wrote:
Are you using a very old version of clang?  As 06a9c7e points out,
our current runes didn't work before clang v3.0.

I'm using clang 3.5 (which have other issue to compile Xen), but I have
also tried 3.0 and 3.3.

If not, rather than chasing this around any further, I think we should
abandon trying to use the compiler-provided headers even on linux.
Does this patch fix your build issue?

commit e7003f174e0df9192dde6fa8d33b0a20f99ce053
Author: Tim Deegan <tim@xxxxxxx>
Date:   Tue Feb 11 12:44:09 2014 +0000

      xen: stop trying to use the system <stdarg.h> and <stdbool.h>

With this patch, -iwithprefix include is not necessary now. I wondering
if we can remove it from the command line.

Yes, I think so.

      We already have our own versions of the stdarg/stdbool definitions, for
      systems where those headers are installed in /usr/include.

      On linux, they're typically installed in compiler-specific paths, but
      finding them has proved unreliable.  Drop that and use our own versions

      Signed-off-by: Tim Deegan <tim@xxxxxxx>

This patch is working fine to build xen clang 3.0, 3.3.
I have others issue to build with clang 3.5.

Tested-by: Julien Grall <julien.grall@xxxxxxxxxx>

Great!  Assuming you'll have a series of patches to fix the clang-3.5
build, do you want to just take this into that series, and drop the
-iwithprefix at the same time?

If it's possible I'd like this patch goes in Xen 4.4 to fix build with official version of clang (until 3.4).

Clang 3.5 is still under development, so I don't think it's important to have support for it in Xen 4.4.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.