[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xen: Don't use -nostdinc flags with CLANG
On 11/02/14 12:35, Tim Deegan wrote: At 12:30 +0000 on 11 Feb (1392118227), Julien Grall wrote:On 11/02/14 08:53, Tim Deegan wrote:At 23:29 +0000 on 10 Feb (1392071374), Julien Grall wrote:Commit 06a9c7e "xen: move -nostdinc into common Rules.mk." breaks compilation with clang: In file included from sched_sedf.c:8: In file included from /home/julieng/works/xen/xen/include/xen/lib.h:5: /home/julieng/works/xen/xen/include/xen/stdarg.h:20:12: error: 'stdarg.h' file not found with <angled> include; use "quotes" instead ^~~~~~~~~~ "stdarg.h"Looks like on your system stdarg.h doesn't live in a compiler-specific path, like we have for the BSDs. I think we should just go to using our own definitions for stdarg/stdbool everywhere; trying to chase the compiler-specific versions around is a PITA, and the pieces we actually need are trivial.For BSDs, we are using our own stdargs/stdbool. So we don't include the system <stdarg.h>. Linux is using $(CC) -print-file-name=include to get the right path. It works with both gcc and clang on Linux distos, but not on FreeBSD.Wait - is the error message you posted from clang on FreeBSD? That's surprising; on FreeBSD xen/stdarg.h shouldn't be trying to include <stdarg.h> at all. Is __FreeBSD__ not being defined? No it's from Linux (Debian Wheezy and Fedora). I just gave a try to the "-print-file-name" solution on FreeBSD. -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |