Re: [Xen-devel] [PATCH v1 04/12] libxl: create a local xenstore libxl and device-model dir for guests

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 10/10/13 13:37, Ian Campbell wrote:
> On Wed, 2013-10-02 at 11:24 +0200, Roger Pau Monne wrote:
>> If libxl is executed inside a guest domain it needs write access to
>> the local libxl xenstore dir (/local/<domid>/libxl) to store internal
>> data. This also applies to Qemu which needs a
>> /local/<domid>/device-model xenstore directory.
>>
>> This patch creates the mentioned directories for each guest launched
>> from libxl.
> 
> Didn't we decide to make this conditional on building a driver domain?

I wasn't really sure about it, so I didn't make that change. I will add it.

>>
>> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
>> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
>> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> ---
>> Changes since RFC:
>>  * Add documentation for the new paths.
>> ---
>>  docs/misc/xenstore-paths.markdown |   10 ++++++++++
>>  tools/libxl/libxl_create.c        |   12 ++++++++++++
>>  2 files changed, 22 insertions(+), 0 deletions(-)
>>
>> diff --git a/docs/misc/xenstore-paths.markdown 
>> b/docs/misc/xenstore-paths.markdown
>> index 1c634b5..a8c4c58 100644
>> --- a/docs/misc/xenstore-paths.markdown
>> +++ b/docs/misc/xenstore-paths.markdown
>> @@ -318,6 +318,16 @@ protocol definition.
>>  
>>  A domain writable path. Available for arbitrary domain use.
>>  
>> +### Driver domain specific paths
>> +
>> +#### ~/device-model/$DOMID/state [w]
>> +
>> +Contains the status of the device models running on the domain.
>> +
>> +#### ~/libxl/$DOMID/qdisk-backend-pid [w]
> 
> Should both of the have BACKEND as a tag too?
> 
> And perhaps some tag to indicate that normal guest functions shouldn't
> use this, similar perhaps to INTERNAL?

Ack, this is inside the "Domain Controlled Paths" section, do you think
it would be best to place it on the "Backend Device Paths" section? Or
maybe create a new "Backend Device Paths" inside of "Domain Controlled
Paths".


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel