Re: [Xen-devel] [PATCH v4 8/9] xen/arm: Implement hypercall for dirty page tracing

[Jaeyong Yoo <jaeyong.yoo@xxxxxxxxxxx>]

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxx [mailto:xen-devel-
> bounces@xxxxxxxxxxxxx] On Behalf Of Ian Campbell
> Sent: Tuesday, October 08, 2013 5:46 PM
> To: jaeyong.yoo@xxxxxxxxxxx
> Cc: Julien Grall; xen-devel@xxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH v4 8/9] xen/arm: Implement hypercall for
> dirty page tracing
> 
> On Tue, 2013-10-08 at 06:29 +0000, Jaeyong Yoo wrote:
> 
> > >> +    /* handle permission fault on write */
> > >> +    if ( page_fault )
> > >> +    {
> > >> +        if ( current->domain->arch.dirty.mode == 0 )
> > >> +           goto bad_data_abort;
> > >> +
> > >> +        handle_page_fault(current->domain, info.gpa);
> > >
> > >You must call advance_pc(regs, hsr) here.
> >
> > I got it.
> 
> Are you sure about this? Eugene's reasoning that we need to replay the
> faulting instruction seemed pretty sound.

Oh, I've got confused. I think Eugene's reasoning is correct.
handle_mmio is for emulating and handle_page_fault is the generic fault,
which should be resolved and repeat the instruction. 
Sorry for the confusion.

Jaeyong

> 
> Ian.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel