Re: [Xen-devel] [PATCH v4 8/9] xen/arm: Implement hypercall for dirty page tracing

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-10-08 at 06:29 +0000, Jaeyong Yoo wrote:

> >> +    /* handle permission fault on write */
> >> +    if ( page_fault )
> >> +    {
> >> +        if ( current->domain->arch.dirty.mode == 0 )
> >> +           goto bad_data_abort;
> >> +
> >> +        handle_page_fault(current->domain, info.gpa);
> >
> >You must call advance_pc(regs, hsr) here.
> 
> I got it.

Are you sure about this? Eugene's reasoning that we need to replay the
faulting instruction seemed pretty sound.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel