[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v1 06/13] x86/PMU: Add public xenpmu.h
>>> On 11.09.13 at 16:03, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote: > On 09/11/2013 04:13 AM, Jan Beulich wrote: >>> --- /dev/null >>> +++ b/xen/include/public/xenpmu.h >> This new file is completely unacceptable as a public header. > > Is this the same comment as IanC made? Mark up public interfaces for > doc generation? > > Or something else? Something else - see the other comments I had given down to about the middle of the file. I stopped there, assuming I provided enough examples of what is bad. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |