Re: [Xen-devel] [PATCH 02 of 11 v5] xen, libxc: introduce xc_nodemap_t

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On mer, 2013-04-10 at 17:18 +0100, Jan Beulich wrote:
> > diff --git a/xen/common/domctl.c b/xen/common/domctl.c
> > --- a/xen/common/domctl.c
> > +++ b/xen/common/domctl.c
> > @@ -117,6 +117,20 @@ int xenctl_bitmap_to_cpumask(cpumask_var
> >      return err;
> >  }
> >  
> > +int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap,
> > +                              const nodemask_t *nodemask)
> > +{
> > +    return bitmap_to_xenctl_bitmap(xenctl_nodemap, cpumask_bits(nodemask),
> 
> This can hardly be cpumask_bits(). If you don't have a similar node
> mask accessor already, you should create one rather than abusing
> the CPU mask one.
> 
Wow... Impressive it survived this late! :-/

There is one, it's nodes_addr(), I just have to use it here.

The patch attached to this mail does that, let me know if it looks
better/fine, as well as if it is fine to pick it up from here, or I have
to respin the whole series.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: libxc-introduce-xc_nodemap_t
Description: Text document

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel