Re: [Xen-devel] [PATCH 3/3] xl: 'xl info' print outstanding claims if enabled (claim_mode=1 in xl.conf)

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Konrad Rzeszutek Wilk writes ("[Xen-devel] [PATCH 3/3] xl: 'xl info' print 
outstanding claims if enabled (claim_mode=1 in xl.conf)"):
> +=item B<outstanding_claims>
> +
> +When a claim call is done (see L<xl.conf>) a reservation for a specific
> +amount of pages is set and also a global value is incremented. This
> +global value (outstanding_claims) is then reduced as the domain's memory
> +is populated and eventually reaches zero. The toolstack can also choose
> +to set the domain's claim to zero which cancels the reservation and
> +decrements the global value by the amount of claim that has not been
> +satisfied. Most of the time the value will be zero, but if you are
> +launching multiple guests, and B<claim_mode> is enabled, this value
> +can increase/decrease.

OK, thanks, this is clear enough in general.

But you need to explain how the user can get the toolstack to set the
domain's claim to zero.

And you need to explain whether the memory counted in
outstanding_claims value is _also_ counted as free memory, or as
memory belonging to its respective domain(s).

> +uint64_t libxl_get_claiminfo(libxl_ctx *ctx)
> +{
> +    long l;
> +
> +    l = xc_domain_get_outstanding_pages(ctx->xch);
> +    if (l < 0) {
> +        LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_WARNING, l, 
> "xc_domain_get_outstanding_pages failed.");

This needs wrapping to 75 columns or so.

Also, is there a way to find out which domain these claims belong to ?
I didn't see it in your previous patch.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel