[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/4] IOMMU: allow MSI message to IRTE propagation to fail

>>> On 27.03.13 at 12:45, George Dunlap <George.Dunlap@xxxxxxxxxxxxx> wrote:
> The inline patches you send are wordwrap-damaged.  I realize that
> you're also attaching the patches, but it's a lot more hassle to
> download each one and manually import it.

I just went out and looked at the copy of the patch you responded
to that I got from xen-devel, and I'm unable to spot any wrapping
issues. On lists.xen.org, I can indeed see an issue in
xen/include/xen/iommu.h, but with this being inconsistent with
the mail I got from xen-devel I can't be sure our mail system is at
fault. During the past couple of years I also haven't had complaints
from others about patches from me coming through line wrapped,
and I know specifically the Linux folks are very picky about this.

> Could you please try out "git send-email"?  There's a basic tutorial here:
> http://wiki.xen.org/wiki/Submitting_Xen_Patches 
> For patches sent with git send-email (or any other method that has the
> patches inline and not whitespace damaged) I have a really efficient
> way to get them from the mailing list into a special git topic branch.
>  It would be nice not to have to special-case yours.

I see your point, but I don't think using git for everything can be a
requirement. I'm used to working with quilt, and have no plans of
changing this, as I simply don't see any benefit in using git in my day
to day coding work. I restrict uses of version control systems in
general to the areas where they're needed - when working on
shared repositories.

Furthermore I don't see why mails sent by means other than the mail
client we use over here wouldn't suffer from similar issues, as they
would still pass the same gateways.

Hence all I can offer is working with our IS&T folks, should we be able
to identify an incompatibility (presumably in mail headers).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.