[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/4] IOMMU: allow MSI message to IRTE propagation to fail

On 27/03/13 12:16, Jan Beulich wrote:
On 27.03.13 at 12:45, George Dunlap <George.Dunlap@xxxxxxxxxxxxx> wrote:
The inline patches you send are wordwrap-damaged.  I realize that
you're also attaching the patches, but it's a lot more hassle to
download each one and manually import it.
I just went out and looked at the copy of the patch you responded
to that I got from xen-devel, and I'm unable to spot any wrapping
issues. On lists.xen.org, I can indeed see an issue in
xen/include/xen/iommu.h, but with this being inconsistent with
the mail I got from xen-devel I can't be sure our mail system is at
fault. During the past couple of years I also haven't had complaints
from others about patches from me coming through line wrapped,
and I know specifically the Linux folks are very picky about this.

Did you look at the mail in your mailreader, or in the raw mail format? If you're using your mail reader, it's probably interpreting the wordwrap stuff properly. The "raw" mail looks like this:


The above is what GMail sees if I click "show original", and also what the Citrix mail system gives me if I save the mail as a file. This mangling is apparently called "quoted-printable": http://en.wikipedia.org/wiki/Quoted-printable

The problem is that "patch" (and thus "git apply", "git am", "hg import", &c &c), not being a mail-reader, doesn't know how to de-mangle stuff.

(I think I was making a mistake by calling it "whitespace mangling"; "wordwrap damage" is I think what I was looking for, even if "quoted-printable" is the technical term.)

Could you please try out "git send-email"?  There's a basic tutorial here:


For patches sent with git send-email (or any other method that has the
patches inline and not whitespace damaged) I have a really efficient
way to get them from the mailing list into a special git topic branch.
  It would be nice not to have to special-case yours.
I see your point, but I don't think using git for everything can be a
requirement. I'm used to working with quilt, and have no plans of
changing this, as I simply don't see any benefit in using git in my day
to day coding work. I restrict uses of version control systems in
general to the areas where they're needed - when working on
shared repositories.

I have no problem with you using whatever tool you find most helpful. I only suggested "git send-email" as one standard, relatively simple and well-documented solution that will generate mail generated in text/plain rather than quoted-printable.

What mail client do you use to send your e-mails?

Furthermore I don't see why mails sent by means other than the mail
client we use over here wouldn't suffer from similar issues, as they
would still pass the same gateways.

Because typically it's the mail client that encodes stuff (and decodes stuff) from plain text into quoted-printable, not mailer demons that translate it. What e-mail client do you use? If there was an option to have it send stuff as "text/plain" rather than quoted-printable, I think that would do it.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.