[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Rename credit2 names to csched2_*

>>> On 01.03.13 at 07:06, Juergen Gross <juergen.gross@xxxxxxxxxxxxxx> wrote:
> On 27.02.2013 13:43, Jan Beulich wrote:
>>>>> On 27.02.13 at 13:19, Juergen Gross<juergen.gross@xxxxxxxxxxxxxx>  wrote:
>>> Functions, variables, structures and macros in the credit2 scheduler had
>>> partially the same names as in the credit scheduler. This makes it hard to
>>> find the correct functions in backtraces or cscope.
>>> Rename all names in credit2 from csched_*/CSCHED_* to csched2_*/CSCHED2_*
>> I don't think this is a suitable approach - if anything, we should aim
>> at having printed static symbols (in backtraces etc) prefixed with
>> their source file name. I would even question quite a few of the
>> csched_ prefixes in credit1...
> Just one other thought: unique names would help for analyzing crash dumps, 
> too.

Only if the crash dump analyzing tool is dumb enough to also
not properly qualify non-global names. ELF has all that is needed
here, just the code consuming ELF symbol tables in the whole
Linux world seems to be ignoring this capability.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.