[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Rename credit2 names to csched2_*

  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Fri, 01 Mar 2013 07:06:02 +0100
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 01 Mar 2013 06:06:37 +0000
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Yxavh5D1tUCWwW2CZ0VfEI32f2DSIn4HC9AVqbO2nlxUTM0zqTZ+reRh GNKCDCUgR3tDF0qEB53EGUAuCPnarBTpq0QyrxUwR604mefT0KtgqTZtL 000w96oKFZmFntikRJjHHVvuy3xPKZKm931MUzbEo8D1aVAhRsob2iuSW 9nZiH8TWTREndjy9mnCMtmyiH4ZavK/rdAlWpwQtU0kSP9h2fBlijT8iR g3/hK5smdd/g5CH3XenbFsfndNszN;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 27.02.2013 13:43, Jan Beulich wrote:
On 27.02.13 at 13:19, Juergen Gross<juergen.gross@xxxxxxxxxxxxxx>  wrote:
Functions, variables, structures and macros in the credit2 scheduler had
partially the same names as in the credit scheduler. This makes it hard to
find the correct functions in backtraces or cscope.

Rename all names in credit2 from csched_*/CSCHED_* to csched2_*/CSCHED2_*

I don't think this is a suitable approach - if anything, we should aim
at having printed static symbols (in backtraces etc) prefixed with
their source file name. I would even question quite a few of the
csched_ prefixes in credit1...

Just one other thought: unique names would help for analyzing crash dumps, too.


Juergen Gross                 Principal Developer Operating Systems
PBG PDG ES&S SWE OS6                   Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.