Re: [Xen-devel] [PATCH 2/2] xl: allow specifying a default netdev in xl.conf

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On 28/01/13 17:11, George Dunlap wrote:
> On Mon, Jan 28, 2013 at 11:00 AM, George Dunlap
> <George.Dunlap@xxxxxxxxxxxxx <mailto:George.Dunlap@xxxxxxxxxxxxx>> wrote:
> 
>     On Fri, Jan 25, 2013 at 3:26 PM, Roger Pau Monne
>     <roger.pau@xxxxxxxxxx <mailto:roger.pau@xxxxxxxxxx>> wrote:
> 
>         This adds a new global option in the xl configuration file called
>         "defaultnetdev", that is used to specify the default netdev to use
>         when none is passed in the vif specification.
> 
> 
>     I'm not a fan of the name, though; it doesn't seem very scalable. 
>     It looks like we already have "defaultbridge', so I can see this is
>     just following precedent, but I wonder if it might be worth putting
>     some more thought into it before proceeding?
> 
>     It seems like if we're going to have a default sub-option, it should
>     at least have the name of the option in which it resides. 
>     "vif_netdev_default" or "default_vif_netdev" seem like better
>     option.  Or maybe "vif.netdev.default"? "defaults.vif.netdev"?

vif_default_netdev sounds good to me, but I don't have any opinions
against the others. We should also add vif_default_bridge (while keeping
the old option). Someone has a strong opinion about any of this names,
or should I just choose the one I prefer?

> 
>     Any thoughts?
> 
> 
> Also, it's probably worth thinking about what other options should have
> defaults.  vif.backend is another one that it seems like it would be
> useful to be able to override (e.g., to make it easy to switch to and
> from driver domains).

Yes, but this should be added when driver domains are done
(vif_default_domain/block_default_domain).


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel