Re: [Xen-devel] [PATCH 2/2] xl: allow specifying a default netdev in xl.conf

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Fri, Jan 25, 2013 at 3:26 PM, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:

This adds a new global option in the xl configuration file called
"defaultnetdev", that is used to specify the default netdev to use
when none is passed in the vif specification.

I'm not a fan of the name, though; it doesn't seem very scalable.  It looks like we already have "defaultbridge', so I can see this is just following precedent, but I wonder if it might be worth putting some more thought into it before proceeding?

It seems like if we're going to have a default sub-option, it should at least have the name of the option in which it resides.  "vif_netdev_default" or "default_vif_netdev" seem like better option.  Or maybe "vif.netdev.default"? "defaults.vif.netdev"?

Any thoughts?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel