[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Is: PVH + ARM new hypercalls. Was: Re: [PATCH]: PVH: specify xen features strings cleany for PVH

>>> On 29.01.13 at 03:57, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> On xen side I added the ifdef:
> #if __XEN_INTERFACE_VERSION__ < 0x00040300
>     unsigned long gdt_frames[16], gdt_ents; /* GDT (machine frames, # ents) 
> */
> #else
>     union {
>         struct {
>             /* GDT (machine frames, # ents) */
>             unsigned long gdt_frames[16], gdt_ents;
>         } pv;
>         struct {
>             /* PVH: GDTR addr and size */
>             unsigned long gdtaddr, gdtsz;
>         } pvh;
>     } u;
> #endif
> but it doesn't matter on linux side, so up to you.

But I'd still prefer for this to go away again - you could simply use
gdt_frames[0] for gdtaddr and gdt_ents for the (normalized)

And if you nevertheless go the union route, call it "gdt" instead
of "u" and drop the gdt/gdt_ prefixes from the member names
(yes, I know, grepping and cscoping for such member is more
difficult, but I continue to see more advantage in avoiding the


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.