[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/4] review For Oracle bug 14470382



>>> On 18.01.13 at 11:08, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> However a single xenbus_printf as used here doesn't need a transaction
> since it is only a single atomic operation.

Right.

> On the other hand I'm not convinced that the initial read of the current
> state didn't ought to be inside the transaction too, although I've not
> thought about it terribly hard...

I don't think so - this is just a safeguard, and I think it could as
well look directly at dev->state.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.